Fix wincrypt symbols conflict #1151
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I've never used boringSSL or wincrypt (I don't have a windows machine), so can you provide a bit more context? I'm not sure what downstream consequences undefining the symbols might have if we do it globally. Maybe we could limit the lines to only execute if there is some kind of Similar issue: |
hudayou
force-pushed
the
wincrypt-boring-ssl
branch
from
b22cca7
to
26273b3
Compare
|
I was trying to make a PR with envoy and their windows CI detected the issue I fixed the problem of BoringSSL with the patch here Looks like there is one So I updated the change with that |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With openssl variants such as boring ssl, the conflict symbols are not undefined such as openssl.
Explicit undefine those so it works for both normal openssl and boring ssl